Open
Conversation
Updated help text for --node-type argument to clarify that multiple values are accepted and scheduling will occur based on the first fitting pool.
There was a problem hiding this comment.
Pull request overview
This PR modifies the --node-type argument in csub.py to accept multiple GPU node pool names instead of just one. This allows users to specify multiple acceptable pools (e.g., --node-type h100 h200), which are joined with commas and passed to the run:ai CLI's --node-pools flag. The preemptibility check is also updated to trigger if any of the specified pools are H100/H200.
Changes:
- Changed
--node-typefrom a single-choice argument tonargs="*"to accept multiple pool names - Updated the
--node-poolsvalue construction to comma-join the list of pools - Updated the preemptibility check to use
any()over the list of pools
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful if you are okay to be scheduled to either of the specified pools